Skip to content

Prompt user for database download on startup#3071

Merged
koesie10 merged 3 commits intomainfrom
koesie10/download-github-database
Nov 20, 2023
Merged

Prompt user for database download on startup#3071
koesie10 merged 3 commits intomainfrom
koesie10/download-github-database

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 14, 2023 •
edited
Loading

This adds a prompt for the user to download a CodeQL database when opening a GitHub repository. This is currently behind the codeQL.githubDatabase.enable feature flag, but this setting is exposed in the VS Code settings UI. This is necessary because updateValue on a setting doesn't do anything unless it's listed in the package.json.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/download-github-database branch from 95913e8 to b190c35 Compare November 14, 2023 13:43
Base automatically changed from koesie10/find-github-repository to main November 17, 2023 13:37
@koesie10 koesie10 force-pushed the koesie10/download-github-database branch from b190c35 to 636f8f1 Compare November 17, 2023 13:46
@koesie10 koesie10 marked this pull request as ready for review November 20, 2023 08:36
@koesie10 koesie10 requested review from a team as code owners November 20, 2023 08:36
@koesie10 koesie10 requested a review from starcke November 20, 2023 08:36
This was referenced Nov 20, 2023
Merged
Merged
starcke
starcke approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, just a few comments and questions.

Comment thread extensions/ql-vscode/package.json
Comment thread extensions/ql-vscode/src/databases/github-database-module.ts Outdated
Comment thread extensions/ql-vscode/src/databases/github-database-prompt.ts
Comment thread extensions/ql-vscode/src/databases/github-database-module.ts
Comment thread extensions/ql-vscode/src/databases/github-database-prompt.ts Outdated
Comment thread extensions/ql-vscode/src/databases/github-database-module.ts
Comment thread extensions/ql-vscode/src/databases/github-database-prompt.ts
Comment thread extensions/ql-vscode/test/vscode-tests/no-workspace/databases/github-database-prompt.test.ts
starcke
starcke approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koesie10 koesie10 merged commit 422f0eb into main Nov 20, 2023
@koesie10 koesie10 deleted the koesie10/download-github-database branch November 20, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starcke starcke starcke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koesie10 @starcke